Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github repo workflow changes #1054

Merged
merged 9 commits into from
Mar 21, 2024
Merged

github repo workflow changes #1054

merged 9 commits into from
Mar 21, 2024

Conversation

tiffanychu90
Copy link
Member

@tiffanychu90 tiffanychu90 commented Mar 20, 2024

  • Attempt to resolve Bug: Netlify preview for portfolio broken #1053
    • Manually turning on GH action does not actually get this working
    • Needs a netlify build statement, but when running python portfolio/portfolio.py, it looks like it's looking for a template within a folder. Given that we no longer check in files to GH, and use LFS, there's no actual _build files to find
    • Investigate more these lines...what will happen if we change it to ./portfolio/{template}?:
for template in ["index.html", "_redirects"]:
        fname = f"./portfolio/index/{template}"
  • Pin netlify cli
  • Fix some typos in our templated issues, analytics.calitp.org -> analysis.calitp.org and remove extra colons

@tiffanychu90 tiffanychu90 marked this pull request as draft March 20, 2024 22:02
@tiffanychu90 tiffanychu90 marked this pull request as ready for review March 20, 2024 22:02
@tiffanychu90 tiffanychu90 marked this pull request as draft March 20, 2024 22:03
@tiffanychu90 tiffanychu90 marked this pull request as ready for review March 20, 2024 22:03
@tiffanychu90 tiffanychu90 merged commit 12bd739 into main Mar 21, 2024
2 checks passed
@tiffanychu90 tiffanychu90 deleted the gh-workflow-updates branch March 21, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Netlify preview for portfolio broken
1 participant