Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a single field to external_airtable #3572

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Dec 5, 2024

Description

Adds a field - holiday_website__from_provider_ - needed for queries.

Type of change

  • New feature

How has this been tested?

Not tested.

If making changes to dbt models, please run the command poetry run dbt run -s CHANGED_MODEL and include the output in this section of the PR.

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

@vevetron vevetron requested a review from evansiroky as a code owner December 5, 2024 19:54
Copy link
Member

@charlie-costanzo charlie-costanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vevetron vevetron merged commit 3c2f4b4 into main Dec 5, 2024
1 check passed
@vevetron vevetron deleted the add_column_external_airtable branch December 5, 2024 20:01
vevetron pushed a commit that referenced this pull request Dec 5, 2024
…seful for holiday mismatches (#3572)"

This reverts commit 3c2f4b4.
vevetron added a commit that referenced this pull request Dec 5, 2024
…seful for holiday mismatches (#3572)" (#3573)

This reverts commit 3c2f4b4.

Co-authored-by: V <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants