new CRS for statewide work in feet #3575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c State Plane zone for SoCal). temporarily ensure compatability pending package update, shouldn't break analyst code
tiffanychu90
approved these changes
Dec 9, 2024
tiffanychu90
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Approving part1 PR. It'd be nice to add part2 PR post-merge follow-ups/actions to be taken for wrapping up the steps listed in: https://docs.calitp.org/data-infra/analytics_tools/python_libraries.html#updating-calitp-data-analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One way to solve #3574.
@csuyat-dot and I found a new CRS option for statewide work in feet (old one was technically a specific State Plane zone for SoCal). It makes sense to rename both CRSs in
geography_utils,but since publishing a newcalitp_data_analysispackage at the exact same time analysts switch their code over might be hard, keep the old names for now as well to ensure compatibility.Type of change
data-analysescode only)How has this been tested?
geopandas can successfully project to our new suggested CRS
Post-merge follow-ups
In data-analyses, switch references to specify
CA_NAD83Albers_ftorCA_NAD83Albers_m, but the previous namesCA_StatePlaneandCA_NAD83Alberswould continue to work.