Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTD: bringing safety and security tables into the warehouse as staging and mart #3583

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

charlie-costanzo
Copy link
Member

@charlie-costanzo charlie-costanzo commented Dec 13, 2024

Description

Following up on #3579, this brings the external tables for safety and security created in that PR into the Warehouse as MVP staging and mart tables.

New staging tables:

  • stg_ntd_safety_and_security__fra_regulated_mode_major_security_events
  • stg_ntd_safety_and_security__major_safety_events
  • stg_ntd_safety_and_security__monthly_modal_time_series_safety_and_service
  • stg_ntd_safety_and_security__nonmajor_safety_and_security_events

New mart tables:

  • fct_safety_and_security__fra_regulated_mode_major_security_events
  • fct_safety_and_security__major_safety_events
  • fct_safety_and_security__monthly_modal_time_series_safety_and_service
  • fct_safety_and_security__nonmajor_safety_and_security_events

Type of change

  • New feature

How has this been tested?

Screenshot 2024-12-13 at 11 07 05 AM

Post-merge follow-ups

  • Actions required (specified below)
    Observe for expected behavior, follow up with documentation, tests, typecasting

@charlie-costanzo charlie-costanzo changed the title bringing ntd safety anf security tables into the warehouse as staging and mart NTD: bringing safety and security tables into the warehouse as staging and mart Dec 13, 2024
@charlie-costanzo charlie-costanzo self-assigned this Dec 13, 2024
@charlie-costanzo charlie-costanzo added the data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner. label Dec 13, 2024
Copy link

Warehouse report 📦

Checks/potential follow-ups

Checks indicate the following action items may be necessary.

  • For new models, do they all have a surrogate primary key that is tested to be not-null and unique?

New models 🌱

calitp_warehouse.mart.safety_and_security.fct_safety_and_security__fra_regulated_mode_major_security_events

calitp_warehouse.mart.safety_and_security.fct_safety_and_security__major_safety_events

calitp_warehouse.mart.safety_and_security.fct_safety_and_security__monthly_modal_time_series_safety_and_service

calitp_warehouse.mart.safety_and_security.fct_safety_and_security__nonmajor_safety_and_security_events

calitp_warehouse.staging.ntd_safety_and_security.stg_ntd_safety_and_security__fra_regulated_mode_major_security_events

calitp_warehouse.staging.ntd_safety_and_security.stg_ntd_safety_and_security__major_safety_events

calitp_warehouse.staging.ntd_safety_and_security.stg_ntd_safety_and_security__monthly_modal_time_series_safety_and_service

calitp_warehouse.staging.ntd_safety_and_security.stg_ntd_safety_and_security__nonmajor_safety_and_security_events

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

@charlie-costanzo charlie-costanzo marked this pull request as ready for review December 13, 2024 16:12
@charlie-costanzo charlie-costanzo merged commit d4d7361 into main Dec 13, 2024
4 checks passed
@charlie-costanzo charlie-costanzo deleted the safety-security-warehouse-tables branch December 13, 2024 20:39
@vevetron
Copy link
Contributor

vevetron commented Jan 14, 2025

fct_major_safety_events has an ntdid, not an ntd_id.
fct_nonmajor_safety_and_security_events has a _5_digit_ntd_id
fct_monthly_modal_time_series_safety_and_service has a _5_digit_ntd_id
fct_fra_regulated_mode_major_security_events has an ntd_id

Hmm.

Those are the ids we had in source data that gets propogated to the mart.

An extension of #3579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants