-
Notifications
You must be signed in to change notification settings - Fork 15
DRAFT Update to GTFS schedule validator v7.1 & add tests (#3763, #4378) #4350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lauriemerrell
wants to merge
17
commits into
main
Choose a base branch
from
3763-update-to-gtfs-schedule-validator-v71
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If any reviewer looks at this -- setting a past cutover date for testing purposes, will bump |
|
TODO: Add pytest checks for the validator jobs |
|
Terraform plan in iac/cal-itp-data-infra-staging/airflow/us Plan: 1 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
!~ update in-place
Terraform will perform the following actions:
# google_storage_bucket_object.calitp-staging-composer-dags["models/intermediate/gtfs_quality/int_gtfs_quality__schedule_validator_rule_details_unioned.sql"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-dags" {
!~ crc32c = "FZrGzA==" -> (known after apply)
!~ detect_md5hash = "xTWjkGqqzCqWNDhJxp6R/w==" -> "different hash"
!~ generation = 1749663120395357 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/models/intermediate/gtfs_quality/int_gtfs_quality__schedule_validator_rule_details_unioned.sql"
!~ md5hash = "xTWjkGqqzCqWNDhJxp6R/w==" -> (known after apply)
name = "data/warehouse/models/intermediate/gtfs_quality/int_gtfs_quality__schedule_validator_rule_details_unioned.sql"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-dags["models/mart/gtfs_quality/_mart_gtfs_quality.yml"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-staging-composer-dags" {
!~ crc32c = "Rs71zQ==" -> (known after apply)
!~ detect_md5hash = "rnq255v0R46m5jQzuY/z0g==" -> "different hash"
!~ generation = 1749663113676778 -> (known after apply)
id = "calitp-staging-composer-data/warehouse/models/mart/gtfs_quality/_mart_gtfs_quality.yml"
!~ md5hash = "rnq255v0R46m5jQzuY/z0g==" -> (known after apply)
name = "data/warehouse/models/mart/gtfs_quality/_mart_gtfs_quality.yml"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-staging-composer-dags["seeds/gtfs_schedule_validator_rule_details_v7_1_0.csv"] will be created
+ resource "google_storage_bucket_object" "calitp-staging-composer-dags" {
+ bucket = "calitp-staging-composer"
+ content = (sensitive value)
+ content_type = (known after apply)
+ crc32c = (known after apply)
+ detect_md5hash = "different hash"
+ generation = (known after apply)
+ id = (known after apply)
+ kms_key_name = (known after apply)
+ md5hash = (known after apply)
+ md5hexhash = (known after apply)
+ media_link = (known after apply)
+ name = "data/warehouse/seeds/gtfs_schedule_validator_rule_details_v7_1_0.csv"
+ output_name = (known after apply)
+ self_link = (known after apply)
+ source = "../../../../warehouse/seeds/gtfs_schedule_validator_rule_details_v7_1_0.csv"
+ storage_class = (known after apply)
}
Plan: 1 to add, 2 to change, 0 to destroy.📝 Plan generated in Plan Terraform for Warehouse and DAG changes #858 |
|
Terraform plan in iac/cal-itp-data-infra/airflow/us Plan: 1 to add, 2 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
!~ update in-place
Terraform will perform the following actions:
# google_storage_bucket_object.calitp-composer-dags["models/intermediate/gtfs_quality/int_gtfs_quality__schedule_validator_rule_details_unioned.sql"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-dags" {
!~ crc32c = "FZrGzA==" -> (known after apply)
!~ detect_md5hash = "xTWjkGqqzCqWNDhJxp6R/w==" -> "different hash"
!~ generation = 1751416661426004 -> (known after apply)
id = "calitp-composer-data/warehouse/models/intermediate/gtfs_quality/int_gtfs_quality__schedule_validator_rule_details_unioned.sql"
!~ md5hash = "xTWjkGqqzCqWNDhJxp6R/w==" -> (known after apply)
name = "data/warehouse/models/intermediate/gtfs_quality/int_gtfs_quality__schedule_validator_rule_details_unioned.sql"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-dags["models/mart/gtfs_quality/_mart_gtfs_quality.yml"] will be updated in-place
!~ resource "google_storage_bucket_object" "calitp-composer-dags" {
!~ crc32c = "Rs71zQ==" -> (known after apply)
!~ detect_md5hash = "rnq255v0R46m5jQzuY/z0g==" -> "different hash"
!~ generation = 1751416667981834 -> (known after apply)
id = "calitp-composer-data/warehouse/models/mart/gtfs_quality/_mart_gtfs_quality.yml"
!~ md5hash = "rnq255v0R46m5jQzuY/z0g==" -> (known after apply)
name = "data/warehouse/models/mart/gtfs_quality/_mart_gtfs_quality.yml"
# (17 unchanged attributes hidden)
}
# google_storage_bucket_object.calitp-composer-dags["seeds/gtfs_schedule_validator_rule_details_v7_1_0.csv"] will be created
+ resource "google_storage_bucket_object" "calitp-composer-dags" {
+ bucket = "calitp-composer"
+ content = (sensitive value)
+ content_type = (known after apply)
+ crc32c = (known after apply)
+ detect_md5hash = "different hash"
+ generation = (known after apply)
+ id = (known after apply)
+ kms_key_name = (known after apply)
+ md5hash = (known after apply)
+ md5hexhash = (known after apply)
+ media_link = (known after apply)
+ name = "data/warehouse/seeds/gtfs_schedule_validator_rule_details_v7_1_0.csv"
+ output_name = (known after apply)
+ self_link = (known after apply)
+ source = "../../../../warehouse/seeds/gtfs_schedule_validator_rule_details_v7_1_0.csv"
+ storage_class = (known after apply)
}
Plan: 1 to add, 2 to change, 0 to destroy.📝 Plan generated in Plan Terraform for Warehouse and DAG changes #858 |
…AR, temporarily override large file size
… of missing env var
c25d59d to
e241830
Compare
c1e8cbb to
000368b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.
Resolves #3763, resolves #4378
Remaining TODOs:
Type of change
How has this been tested?
Include commands/logs/screenshots as relevant.
If making changes to dbt models, please run the command
poetry run dbt run -s CHANGED_MODELandpoetry run dbt test -s CHANGED_MODEL, then include the output in this section of the PR.Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.