-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: switch
args style
#72
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
was using the old switch syntax, and was disabled anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice change and everything worked as expected 👍
The only thing I noticed was that we may be missing a test for when switch
raises a ValueError
. I don't think it's super important but if we think it'll help we could add one more test to test_switch.py
just to make sure line 7 is covered:
def test_switch_missing_args():
with pytest.raises(ValueError):
switch()
Thanks for this suggestion. Added in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and will be really nice to use 🙏
Closes #71