generated from cal-itp/mkdocs-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling separation of trips and runs via trip_service_ids #80
Open
jeffkessler-keolis
wants to merge
9
commits into
cal-itp:main
Choose a base branch
from
jeffkessler-keolis:separate_run_service_ids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enabling separation of trips and runs via trip_service_ids #80
jeffkessler-keolis
wants to merge
9
commits into
cal-itp:main
from
jeffkessler-keolis:separate_run_service_ids
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extra staffing for a special event Different runs mapping to the same set of trips Variations of runs by day of the week Jobs of entirely nonrevenue operations
Note from working group conversation:
|
skyqrose
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a bunch of comments, but they're just about details and examples. As a whole, I like the proposal, especially after the idea from the working group about removing the trip_service_id
column.
remove run_events.trip_service_id from spec and trim examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In This Change
Per #76, this change:
service_id
, which was not possible beforehand.service_id
s per the above.Modifications
trip_service_id
would be able to do so without modification.trip_service_id
) in the primary key fields ofrun_events.txt
.Benefits
run_events.txt
in the current design, as it is impossible to modify underlying runs without also modifying the public GTFS, as is not always possible.Multiple examples are included herein. For more details, see #76.