Fixing incorrect Median VP Latency Graph in the monthly report website #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsalemi
requested review from
edasmalchi,
vevetron and
csuyat-dot
as code owners
|
Preview url: https://PR-323--cal-itp-reports.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The median vehicle position latency displayed on the report website is showing incorrectly inflated numbers. This issue is caused by referencing the wrong table.
Current Table Used:
fct_daily_vehicle_positions_message_age_summaryCorrect Table to Use:
fct_daily_vehicle_positions_latency_statisticsProposed Fix:*
The table used to generate the monthly median vehicle position (VP) latency graph should be updated to the correct table:
fct_daily_vehicle_positions_latency_statistics.In this PR, I am correcting this issue.
Resolves # 322
Type of change