Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dataformats for non-deprecated comparisons #328

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Jan 8, 2025

…parisons

Description

Changes some data formats so we don't get errors anymore. Comparing datetimes to timestamps still seems super messy though, not sure what a better way should be.

Resolves #325

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

poetry run make data
Ran locally to produce data, works now. Visually checked data types and compared to known working data, looks okay. But have not looked at it in a website.
edit - Built website locally and compared it to current production site and it looks good.

2_ave_median_tu_age.json
[
    {
        "organization_name": "Alameda-Contra Costa Transit District",
        "calitp_itp_id": 4,
        "service_date": 1717200000000,
        "avg_median_trip_update_message_age": 159.6283524904
    },
2_ave_median_vp_age.json
    {
        "organization_name": "Alameda-Contra Costa Transit District",
        "calitp_itp_id": 4,
        "service_date": 1717200000000,
        "avg_median_vehicle_message_age": 16.0
    },

Screenshots (optional)

Copy link

github-actions bot commented Jan 8, 2025

Preview url: https://PR-328--cal-itp-reports.netlify.app

@vevetron vevetron force-pushed the comparison_fixes branch 2 times, most recently from cf5f4e8 to 9788201 Compare January 8, 2025 01:05
@vevetron
Copy link
Contributor Author

vevetron commented Jan 8, 2025

Built website locally and compared it to current production site and it looks good.

Copy link
Member

@edasmalchi edasmalchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vevetron vevetron merged commit 8d2bec0 into main Jan 8, 2025
2 checks passed
@vevetron vevetron deleted the comparison_fixes branch January 8, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Warning popping up during Make data timestamp - python related
2 participants