Improve handling of deprecated ctors that are still used in Packet.hpp

soup/BufferWriter.hpp

@@ -16,7 +16,7 @@ NAMESPACE_SOUP
 		{
 		}
 
-		[[deprecated]] BufferWriter(Endian endian)
+		/* deprecated */ BufferWriter(Endian endian)
 			: Writer(endian)
 		{
 		}

soup/IstreamReader.hpp

@@ -11,7 +11,12 @@ NAMESPACE_SOUP
 	public:
 		std::istream& is;
 
-		IstreamReader(std::istream& is, Endian endian = ENDIAN_LITTLE)
+		IstreamReader(std::istream& is)
+			: Reader(ENDIAN_LITTLE), is(is)
+		{
+		}
+
+		/* deprecated */ IstreamReader(std::istream& is, Endian endian)
 			: Reader(endian), is(is)
 		{
 		}

soup/MemoryRefReader.hpp

@@ -15,13 +15,24 @@ NAMESPACE_SOUP
 		size_t size;
 		size_t offset = 0;
 
-		MemoryRefReader(const void* _data, size_t size, bool little_endian = true)
+		MemoryRefReader(const void* _data, size_t size)
+			: Reader(true), data(reinterpret_cast<const uint8_t*>(_data)), size(size)
+		{
+		}
+
+		/* deprecated */ MemoryRefReader(const void* _data, size_t size, bool little_endian)
 			: Reader(little_endian), data(reinterpret_cast<const uint8_t*>(_data)), size(size)
 		{
 		}
 
 		template <typename T, SOUP_RESTRICT(!std::is_pointer_v<T>)>
-		MemoryRefReader(const T& t, bool little_endian = true)
+		MemoryRefReader(const T& t)
+			: MemoryRefReader(t.data(), t.size(), true)
+		{
+		}
+
+		template <typename T, SOUP_RESTRICT(!std::is_pointer_v<T>)>
+		/* deprecated */ MemoryRefReader(const T& t, bool little_endian)
 			: MemoryRefReader(t.data(), t.size(), little_endian)
 		{
 		}

soup/OstreamWriter.hpp

@@ -9,7 +9,12 @@ NAMESPACE_SOUP
 	public:
 		std::ostream& os;
 
-		OstreamWriter(std::ostream& os, Endian endian = ENDIAN_LITTLE)
+		OstreamWriter(std::ostream& os)
+			: Writer(ENDIAN_LITTLE), os(os)
+		{
+		}
+
+		/* deprecated */ OstreamWriter(std::ostream& os, Endian endian)
 			: Writer(endian), os(os)
 		{
 		}

soup/StringReader.hpp

@@ -12,17 +12,27 @@ NAMESPACE_SOUP
 		std::string data;
 		size_t offset = 0;
 
-		StringReader(Endian endian = ENDIAN_LITTLE) noexcept
+		StringReader() noexcept
+			: Reader(ENDIAN_LITTLE)
+		{
+		}
+
+		/* deprecated */ StringReader(Endian endian) noexcept
 			: Reader(endian)
 		{
 		}
 
-		StringReader(std::string&& data, Endian endian = ENDIAN_LITTLE) noexcept
+		StringReader(std::string&& data) noexcept
+			: Reader(ENDIAN_LITTLE), data(std::move(data))
+		{
+		}
+
+		/* deprecated */ StringReader(std::string&& data, Endian endian) noexcept
 			: Reader(endian), data(std::move(data))
 		{
 		}
 
-		StringReader(std::string&& data, bool little_endian) noexcept
+		/* deprecated */ StringReader(std::string&& data, bool little_endian) noexcept
 			: Reader(little_endian), data(std::move(data))
 		{
 		}

soup/StringWriter.hpp

@@ -9,12 +9,17 @@ NAMESPACE_SOUP
 	public:
 		std::string data{};
 
-		StringWriter(Endian endian = ENDIAN_LITTLE)
+		StringWriter()
+			: Writer(ENDIAN_LITTLE)
+		{
+		}
+
+		/* deprecated */ StringWriter(Endian endian)
 			: Writer(endian)
 		{
 		}
 
-		StringWriter(bool little_endian)
+		/* deprecated */ StringWriter(bool little_endian)
 			: Writer(little_endian)
 		{
 		}