Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor 0.47r #131

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Constructor 0.47r #131

merged 2 commits into from
Apr 14, 2024

Conversation

hexarobi
Copy link
Contributor

If I am updating an existing package...

  • I have ensured that all modified files now have a different URL.
  • If resources were modified, I also made sure to bump the resources_version.

@Sainan
Copy link
Member

Sainan commented Apr 14, 2024 •
edited
Loading

The lua/auto-updater package is already at the latest version with repository patches applied (disabling self-updating). The Constructor package can depend on it being up-to-date and does not need to ship its own version. Or rather, it mustn't, because the same library name can not be reused.

@Sainan Sainan merged commit a87fd48 into calamity-inc:main Apr 14, 2024
1 check passed
@hexarobi
Copy link
Contributor Author

The lua/auto-updater package is already at the latest version with repository patches applied (disabling self-updating). The Constructor package can depend on it being up-to-date and does not need to ship its own version. Or rather, it mustn't, because the same library name can not be reused.

hmm ya, didnt mean to include auto-update changes here, thats why I made a separate MR. sorry about that. removed them now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hexarobi @Sainan