Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor 0.51 #146

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Constructor 0.51 #146

merged 1 commit into from
Jun 8, 2024

Conversation

hexarobi
Copy link
Contributor

@hexarobi hexarobi commented Jun 8, 2024

refactor file loaders into convertors

If I am updating an existing package...

  • I have ensured that all modified files now have a different URL.
  • If resources were modified, I also made sure to bump the resources_version.

refactor file loaders into convertors
@Sainan
Copy link
Member

Sainan commented Jun 8, 2024

All you did is refactor code and call it a new major version? A refactor doesn't require an update at all.

@hexarobi
Copy link
Contributor Author

hexarobi commented Jun 8, 2024

All you did is refactor code and call it a new major version? A refactor doesn't require an update at all.

This is to support other scripts

@Sainan
Copy link
Member

Sainan commented Jun 8, 2024

Seems like this package may want to be split to create a separate "libconstructor", then.

@Sainan Sainan merged commit eae084a into calamity-inc:main Jun 8, 2024
1 check passed
@hexarobi
Copy link
Contributor Author

hexarobi commented Jun 8, 2024

Seems like this package may want to be split to create a separate "libconstructor", then.

ya I was thinking the same thing. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants