Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatCommander update #153

Merged
merged 2 commits into from
Jun 25, 2024
Merged

ChatCommander update #153

merged 2 commits into from
Jun 25, 2024

Conversation

hexarobi
Copy link
Contributor

  • Fix error for missing class on croquette

If I am updating an existing package...

  • I have ensured that all modified files now have a different URL.
  • If resources were modified, I also made sure to bump the resources_version.

- Fix error for missing class on croquette
@Sainan
Copy link
Member

Sainan commented Jun 25, 2024

You need to bump the version.

@Sainan
Copy link
Member

Sainan commented Jun 25, 2024

Btw., I did tell you the new class name is "classic", it's also documented now.

@Sainan Sainan merged commit b767ce0 into calamity-inc:main Jun 25, 2024
1 check passed
@hexarobi
Copy link
Contributor Author

Btw., I did tell you the new class name is "classic", it's also documented now.

cool. will it be added to the joatt dictionary? this update skips over the vehicle if the class is nil, but if needed i can add some custom code for it maybe

@Sainan
Copy link
Member

Sainan commented Jun 25, 2024

Vehicle classes are not the joaat dictionary. The only guarantee you are given is that they are valid Stand label hashes, and this still holds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants