Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added continuity text when a dot is selected #71

Merged
merged 2 commits into from
Sep 1, 2014

Conversation

brandonchinn178
Copy link
Contributor

#58

@noahsark769
Copy link
Contributor

Looks initially good, a few style fixes:

  1. Can we use a class other than .js-continuity-text in the less file? The idea behind using js-prefixed classes is to differentiate classes used for style and classes used for ui updates: so the selector we use in the js file should be js-prefixed, but the one in the less file should not.
  2. Why the absolute positioning? It looks like the point is for continuity texts to be on a different line than the beat/stunt sheet displays, but if that's the case we should put them inside a block level element instead. Also, the individual continuity texts should be in their own

    elements rather than being separated by new lines. @kmdurand can send you the files for vive la france and pink for test cases!

  3. On line 213-6 in AnimationStateDelegate, those variables should declared with var, or else they'll go in the global scope which is no good.

@brandonchinn178
Copy link
Contributor Author

Done! Did so much Python, forgot about using "var"!

@kmdurand
Copy link
Contributor

looking good to me!

@noahsark769
Copy link
Contributor

Looks good, shipping it!

noahsark769 added a commit that referenced this pull request Sep 1, 2014
Added continuity text when a dot is selected
@noahsark769 noahsark769 merged commit d4eaec1 into master Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants