Get code coverage working. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CLI "reporters" option was overriding the config file's config. Source maps aren't working yet, but at least SOMETHING works now.
| @@ -31,6 +34,7 @@ | |||
| "brunch": "^2.10.9", | |||
| "chai": "^3.5.0", | |||
| "eslint": "^3.15.0", | |||
| "istanbul": "jacksonrayhamilton/istanbul#09f9660", | |||
There was a problem hiding this comment.
My fork of istanbul is off the last released version (0.4.5) and fixes this bug which would otherwise occur when generating the HTML report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
karma-coverage seems to fail at resolving source files, see: karma-runner/karma-coverage#202
I adapted the instructions from this package: https://github.com/jas-chen/karma-sourcemap-writer (the package itself did not seem to actually be necessary)
We are using remap-istanbul to resolve the source files like suggested here: https://github.com/SitePen/remap-istanbul/wiki/Karma-How-To
And finally we generate the HTML report ourself, filtering only the source files in this application.