added perfdata

[dgoetz]

Hello,

I have added perfdata to the plugin output. I think this should be default, but if you think perfdata should be optional let me know and I will add a parameter for enabling/disabling.

Regards,
Dirk

[calestyo]

I think this (and following) should rather read something like "non-security-updates=" or so - otherwise it's ambiguous whether or not this number includes security updates.

[calestyo]

Hey.

Sorry for having ignored this for so long… well I'm basically in ultra-low-maintenance mode of check_yum ;-)

As for your pull request,... I have nothing against adding perf-data, neither against having it on per default.

• But I do think there should be an option to disable it.
• Further I made some first comments on your code…

Cheers,
Chris

[calestyo]

I've looked at this again,... first we should consider https://www.monitoring-plugins.org/doc/guidelines.html#AEN201

Second, I think:
Whenever --all-updates is used, then check_yum doesn't differentiate between security/non-security updates.
So we should actually have three possible perfdata values that may appear:
updates=total number of updates
security-update=security updates, if separately determined
non-security-update=non-security updates, if separately determined

Further, I've checked the checks from monitoring-plugins.org, well at least check_load,... and it doesn't contain an option to disable the perfdata,... so I think we don't need either.