Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce a secret key for encryption type into context identity #863
feat: introduce a secret key for encryption type into context identity #863
Changes from 22 commits
38fb2c9
592e4ff
bfffe65
9d35b3c
3f93c7f
e108eb3
0fb78fb
f8947a2
fdbec1b
78b28b0
43562e4
2d79779
579111b
9de785d
423dc45
c569183
d6c6afe
c891866
0feaf62
9d0f433
7e5c7d1
6833399
d2394e9
ee2e576
b915d70
aaa794c
da327c3
6e9915b
cb812dd
b3175b9
ded8cbf
f8a4826
aa063e2
af59c24
d833c87
c2e2b6c
025ecd3
6033af0
a7087f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought I'd mention.. ideally, IVs shouldn't be constant as that impairs the effectiveness of GCM encryption and this can be passed in plain text, but that's an easy fix for a later PR, we can merge with this