Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_formatted_array #495

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Remove get_formatted_array #495

merged 16 commits into from
Oct 24, 2023

Conversation

brynpickering
Copy link
Member

Fixes issue raised in a comment in #494.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

sjpfenninger
sjpfenninger previously approved these changes Oct 24, 2023
Copy link
Member

@sjpfenninger sjpfenninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, assuming the tests pass!

Base automatically changed from update-param-names to main October 24, 2023 10:26
@brynpickering brynpickering dismissed sjpfenninger’s stale review October 24, 2023 10:26

The base branch was changed.

@brynpickering brynpickering merged commit 50fa6fc into main Oct 24, 2023
7 checks passed
@brynpickering brynpickering deleted the remove-get-formatted-array branch October 24, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants