Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature modulegraph and cleanup #1

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feature modulegraph and cleanup #1

wants to merge 7 commits into from

Conversation

irm-codebase
Copy link
Collaborator

@irm-codebase irm-codebase commented Sep 13, 2024 •
edited
Loading

This PR has two objectives:

  • Cleaning up ec_utils and setting it up to grow in a healthier way over time.
    • moved to pyproject.toml with dynamic dependencies
    • Added tests
    • we now use the src/ec_utils configuration since it's recommended by pytest
    • added CI checks (ruff, no large files, yaml format, etc)
    • removed the scripts in docs, since they were model specific
  • Add modulegraph to make our DAGs look sane.

test

@irm-codebase irm-codebase self-assigned this Sep 13, 2024
@irm-codebase irm-codebase marked this pull request as draft September 16, 2024 14:05
@irm-codebase irm-codebase marked this pull request as ready for review September 16, 2024 15:34
@irm-codebase
Copy link
Collaborator Author

modulegraph works for rulegraphs and dags. filegraphs do not work because snakemake uses html for them.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpfenninger sjpfenninger Awaiting requested review from sjpfenninger

At least 1 approving review is required to merge this pull request.

Assignees

@irm-codebase irm-codebase

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@irm-codebase