Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to hydro power database release 07 #19

Closed
timtroendle opened this issue May 28, 2020 · 5 comments · Fixed by #48 or #58
Closed

Update to hydro power database release 07 #19

timtroendle opened this issue May 28, 2020 · 5 comments · Fixed by #48 or #58
Labels
data enhancement New feature or request hydro Issues related to hydroelectricity
Milestone
1.1

Comments

@timtroendle
Copy link
Member

timtroendle commented May 28, 2020 •
edited
Loading

https://github.com/energy-modelling-toolkit/hydro-power-database/releases/tag/v7
@timtroendle timtroendle added enhancement New feature or request hydro Issues related to hydroelectricity labels May 28, 2020
@timtroendle
Copy link
Member Author

See also #8 .

@timtroendle timtroendle linked a pull request Jun 8, 2020 that will close this issue
Update to hydro power database release 05 #27
Closed
@timtroendle timtroendle added this to the 1.1 milestone Jun 8, 2020
@timtroendle timtroendle changed the title Update to hydro power database release 05 Update to hydro power database release 06 Jul 8, 2020
@timtroendle timtroendle changed the title Update to hydro power database release 06 Update to hydro power database release 07 Feb 10, 2021
@timtroendle timtroendle linked a pull request Feb 10, 2021 that will close this issue
Update JRC Hydro Database version #43
Closed
@timtroendle timtroendle mentioned this issue Apr 7, 2021
Closed
@brynpickering brynpickering mentioned this issue Apr 7, 2021
Merged
@timtroendle timtroendle linked a pull request Apr 7, 2021 that will close this issue
update-jrc-hydro-from-develop #48
Merged
@timtroendle
Copy link
Member Author

timtroendle commented Apr 8, 2021 •
edited
Loading

The dataset as introduced in #48 does not work: it contains unknown country codes. First, it contains entries for Kosovo. Second, it contains EU country codes instead of ISO 3166 country codes.

@timtroendle timtroendle reopened this Apr 8, 2021
@brynpickering
Copy link
Member

😔

@timtroendle
Copy link
Member Author

timtroendle commented Apr 8, 2021 •
edited
Loading

I'm fixing it right now. Still, this is the third issue in less than 24h that could have been caught by CI. We should try to tackle #56 in some way.

@timtroendle
Copy link
Member Author

There is another issue with 07: there are 4 duplicated indices in the dataset. See https://github.com/energy-modelling-toolkit/hydro-power-database/releases/tag/v8.

@timtroendle timtroendle mentioned this issue Apr 8, 2021
Closed
timtroendle added a commit to timtroendle/euro-calliope that referenced this issue Apr 8, 2021
@timtroendle
Fix issues with JRC hydro stations database v07
085a241 
Fixes calliope-project#19.
@timtroendle timtroendle mentioned this issue Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data enhancement New feature or request hydro Issues related to hydroelectricity
Projects
None yet
Milestone
1.1
2 participants
@timtroendle @brynpickering