-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JRC Hydro Database version #43
Conversation
Even more relevant: this PR moves from Geth PHS storage capacities to JRC PHS storage capacities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version update is very nice, thanks!
Moving away from Geth data may be fine, but it would be good to understand the consequences. See my comment.
@@ -2,7 +2,6 @@ URL_LOAD = "https://data.open-power-system-data.org/time_series/2019-06-05/time_ | |||
URL_POTENTIALS = "https://zenodo.org/record/3533038/files/possibility-for-electricity-autarky.zip" | |||
URL_CAPACITY_FACTORS = "https://zenodo.org/record/3899687/files/{wildcards.filename}?download=1" | |||
|
|||
NATIONAL_PHS_STORAGE_CAPACITIES = "data/pumped-hydro/storage-capacities-gwh.csv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be deleted as it's not necessary anymore.
In terms of changes, they are below. There are some big differences, but I have been reliably informed that the Italian data is much more realistic in JRC than in Geth et al. (and there is an order of magnitude difference between the two). So, it might not be that JRC was vastly overestimating, but that Geth was vastly underestimating...
|
Geth is certainly an underestimation as they say themselves they do not cover all plants. The numbers are dramatically different sometimes though, and I personally simply don't know which one's better. What do you think of keeping Geth data and the scaling mechanism as an option? |
@timtroendle I will update this once #45 is merged in. I will allow one to set a binary config option to scale capacities based on Geth, and default it to False. |
When updating, could you separate this PR into two: one for updating the data (solving #19) and one for making Geth optional? The two do not seem linked to me and the later is a big change. |
It would be much easier to keep them in this PR, if that's OK. They are linked in that updating the JRC hydro database is moving closer to the 'reality' of PHS capacity (as that database can be assumed to have only improved), which thus makes the Geth scaling possibly unnecessary, hence that change. |
Ignore that, I'll split them as I ned to rebase onto |
From V4 to V7, and update the method extracting data from the zip to be version hash agnostic.