Update sorting method in ehighways renaming #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtroendle
approved these changes
Jun 19, 2024
| order = ( | ||
| units.id.str.extractall(r"(\d+)") | ||
| .groupby(level=0) | ||
| .sum() |
There was a problem hiding this comment.
Not exactly clear to me what you are summing here. Maybe a comment would be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397.
The initial method was string sorting so that [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11] would be sorted as [1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11].
This will now sort the abovementioned example correctly, but also handle ordering of
1-1.1,1-2.1etc. by extracting all digits from the string and then combining them together into a new number (111, 121 in this example).Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.