Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -o option to unzip calls #423

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Add -o option to unzip calls #423

merged 3 commits into from
Aug 7, 2024

Conversation

brynpickering
Copy link
Member

@brynpickering brynpickering commented Aug 2, 2024

Fixes #327

Checklist

Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.

  • CHANGELOG updated
  • Minimal workflow tests pass
  • Tests added to cover contribution
  • Documentation updated
  • Configuration schema updated

Copy link
Member

@timtroendle timtroendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how this is solving the issue #327. I would still be reluctant to merge this, because #327 should never happen. Snakemake should take care that the file to be generated is deleted before executing the rule.

I recommend to first better understand #327. Can we reproduce it? Maybe it's a bug in Snakemake? Maybe that bug is solved already in some newer version? Maybe we can solve the bug ourselves?

@brynpickering
Copy link
Member Author

It happens for me too. It's because the output is just one of the files that is unzipped, not all of them. I can fix it properly in this instance, but there are other instances in which -o is used.

EDIT: I have now cleaned these up to all be able to unzip without needing -o by only extracting the files that are actually needed.

rules/wind-and-solar.smk Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@brynpickering brynpickering merged commit e9cb908 into develop Aug 7, 2024
4 checks passed
@brynpickering brynpickering deleted the overwrite-on-unzip branch August 7, 2024 12:37
jnnr pushed a commit to jnnr/euro-calliope that referenced this pull request Aug 27, 2024
jnnr pushed a commit to jnnr/euro-calliope that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow silently hangs if basins_database tries to unzip when build/data/basins is already populated
2 participants