Add synthetic fuel production & methane boiler #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynpickering
force-pushed
the
add-synfuels
branch
from
b8a3ff5
to
4b805d1
Compare
|
To note: the synfuel transmission and the need for the "dummy" techs to convert synfuels to fuels will likely disappear when using v0.7. They are there now to be able to distinguish between synthetic fuels and fossil fuels (when I add those) for custom constraints but I think we can circumvent all that with our v0.7 math. |
for more information, see https://pre-commit.ci
timtroendle
requested changes
Aug 6, 2024
templates/models/techs/conversion/hydrogen-from-electricity.yaml.jinja
Outdated
Show resolved
Hide resolved
templates/models/techs/conversion/synfuels-from-hydrogen.yaml.jinja
Outdated
Show resolved
Hide resolved
templates/models/techs/conversion/synfuels-from-hydrogen.yaml.jinja
Outdated
Show resolved
Hide resolved
- Remove synfuel transmission - Remove `syn_` prefix on fuels - TODO -> ASSUME - Remove unused fixture
timtroendle
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this should be reviewed after #419 since it builds on it (I am opening this PR as I will be offline for a few days but still want it to be possible for this to be reviewed once #419 is merged).
Fixes #416.
Checklist
Any checks which are not relevant to the PR can be pre-checked by the PR creator. All others should be checked by the reviewer. You can add extra checklist items here if required by the PR.