Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not being able to tag without also committing #114

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

petterroea
Copy link

Fixes #113

Please note: I have no experience with mercurial, and as such I do not know if mercurial would allow tagging without committing.

Tests are also updated and are all green.

@petterroea
Copy link
Author

(I also tested that this PR causes my wanted behavior to appear by running the same command as in the issue again)

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8ea252) 93.06% compared to head (753c990) 93.04%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   93.06%   93.04%   -0.02%     
==========================================
  Files          19       19              
  Lines        1254     1251       -3     
  Branches      258      257       -1     
==========================================
- Hits         1167     1164       -3     
  Misses         58       58              
  Partials       29       29              
Flag Coverage Δ
python-3.10 93.04% <100.00%> (-0.02%) ⬇️
python-3.11 93.04% <100.00%> (-0.02%) ⬇️
python-3.8 93.04% <100.00%> (-0.02%) ⬇️
python-3.9 93.04% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coordt coordt changed the base branch from master to decouple-commit-and-tag December 29, 2023 12:59
@coordt coordt merged commit df4ef17 into callowayproject:decouple-commit-and-tag Dec 29, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to tag if a commit is not being made
2 participants