Support node 14 #758
Merged
Support node 14 #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves Module.createRequireFromPath() is deprecated
Node 14 has made it to long term support, and it crashes when used with Haul. To fix this I've bumped
@types/nodeto currtent, and addedModule.createRequirewith fallback toModule.createRequireFromPathwhere onlyModule.createRequireFromPathwas used before.In addition I fixed type errors that came with the
@types/nodeupdate.Test plan
I'm not sure how best to test, I ran the jest tests locally, and failed 7 test suites, 10 tests, and 3 snapshots on the PR branch vs 10 test suites, 15 tests and 3 snapshots on master. Looks like createRequireFromPath and createRequire are equivalent api equivalent, apart from createRequire supporting URL input, so they should be swappable.