Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use % threshold for duration diff #541

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Oct 28, 2024

Summary

Modify min duration threshold for significant changes from absolute 4ms to relative 5% difference. Results from #534 significantly improving measurement precision.

Test plan

Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: e884709

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Performance Comparison Report

  • Current: HEAD (3d3c80b) - 2024-10-28 09:45:53Z
  • Baseline: main (d69abb3) - 2024-10-28 09:45:08Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 81.8 ms → 85.5 ms (+3.6 ms, +4.4%) 7 → 7
fib 30 function 38.4 ms → 38.4 ms (+0.1 ms, ±0.0%) 1 → 1
fib 31 function 62.1 ms → 62.1 ms (+0.0 ms, ±0.0%) 1 → 1
fib 32 function 100.7 ms → 102.2 ms (+1.5 ms, +1.5%) 1 → 1
InitialRenders 1 render 1.1 ms → 1.1 ms (-0.0 ms, -3.6%) 2 → 2
InitialRenders 3 render 1.2 ms → 1.2 ms (+0.0 ms, +1.0%) 4 → 4
ManyRenderIssues render 1.4 ms → 1.4 ms (-0.0 ms, -2.0%) 5 → 5
Other Component render 51.5 ms → 52.8 ms (+1.3 ms, +2.4%) 4 → 4
Other Component 20 run render 51.3 ms → 53.3 ms (+2.0 ms, +3.9%) 4 → 4
RedundantUpdates render 0.8 ms → 0.8 ms (-0.0 ms, -0.5%) 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 81.8 ms
Stdev: 0.3 ms (0.4%)
Runs: 81.8 82.1 81.8 82.2 81.3 81.7 81.4 81.7 82.1 82.2
Warmup runs: 85.7

Current
Mean: 85.5 ms
Stdev: 0.5 ms (0.6%)
Runs: 85.3 84.7 86.5 85.5 85.7 85.6 85.2 85.4 85.1 85.4
Warmup runs: 91.7
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 38.4 ms
Stdev: 0.1 ms (0.2%)
Runs: 38.4 38.4 38.3 38.4 38.3 38.4 38.4 38.5 38.3 38.4
Warmup runs: 35.6

Current
Mean: 38.4 ms
Stdev: 0.1 ms (0.3%)
Runs: 38.4 38.3 38.7 38.4 38.4 38.4 38.5 38.5 38.3 38.4
Warmup runs: 35.6
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.1 ms
Stdev: 0.1 ms (0.1%)
Runs: 62.1 62.1 62.1 62.0 62.3 62.1 62.1 62.0 62.1 62.2
Warmup runs: 62.2

Current
Mean: 62.1 ms
Stdev: 0.1 ms (0.2%)
Runs: 62.1 62.1 62.1 62.1 62.5 62.1 62.1 62.0 62.2 62.1
Warmup runs: 62.2
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 100.7 ms
Stdev: 1.0 ms (1.0%)
Runs: 100.4 100.4 100.4 100.5 100.4 103.5 100.4 100.4 100.5 100.5
Warmup runs: 100.5

Current
Mean: 102.2 ms
Stdev: 4.5 ms (4.4%)
Runs: 100.4 100.7 100.6 100.8 100.8 100.9 101.9 115.0 100.5 100.4
Warmup runs: 100.5
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 1.1 ms
Stdev: 0.2 ms (19.4%)
Runs: 1.6 1.4 1.1 1.2 1.1 0.8 1.1 1.1 0.9 1.1
Warmup runs: 129.6

Current
Mean: 1.1 ms
Stdev: 0.2 ms (16.4%)
Runs: 1.4 1.3 1.1 1.2 1.1 0.9 1.0 1.0 0.9 1.0
Warmup runs: 9.4
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.2 ms
Stdev: 0.1 ms (5.7%)
Runs: 1.2 1.4 1.2 1.2 1.2 1.2 1.2 1.2 1.2 1.3
Warmup runs: 1.2

Current
Mean: 1.2 ms
Stdev: 0.1 ms (7.9%)
Runs: 1.2 1.4 1.2 1.2 1.2 1.2 1.2 1.2 1.2 1.4
Warmup runs: 1.3
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.4 ms
Stdev: 0.0 ms (3.5%)
Runs: 1.4 1.4 1.4 1.4 1.4 1.5 1.4 1.4 1.5 1.4
Warmup runs: 1.4

Current
Mean: 1.4 ms
Stdev: 0.0 ms (1.4%)
Runs: 1.4 1.4 1.3 1.4 1.4 1.4 1.4 1.4 1.4 1.4
Warmup runs: 1.4
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Other Component render Baseline
Mean: 51.5 ms
Stdev: 1.0 ms (1.9%)
Runs: 50.8 54.2 51.0 51.4 51.3 51.3 51.4 51.1 51.6 51.3
Warmup runs: 57.7

Current
Mean: 52.8 ms
Stdev: 0.3 ms (0.6%)
Runs: 52.6 52.2 53.0 53.2 52.6 52.5 52.8 53.2 52.8 53.1
Warmup runs: 56.1
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 run render Baseline
Mean: 51.3 ms
Stdev: 0.3 ms (0.6%)
Runs: 51.5 51.6 52.0 51.6 51.2 51.3 51.3 51.7 51.6 51.4 51.1 51.2 51.1 51.3 51.2 51.9 51.1 50.9 50.9 50.8
Warmup runs: 51.4

Current
Mean: 53.3 ms
Stdev: 1.6 ms (3.0%)
Runs: 53.3 53.2 53.6 53.6 52.6 52.9 52.9 52.8 52.8 52.7 52.8 52.8 53.0 52.5 53.0 59.9 52.9 53.2 52.4 53.5
Warmup runs: 53.2
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
RedundantUpdates render Baseline
Mean: 0.8 ms
Stdev: 0.0 ms (4.8%)
Runs: 0.9 0.9 0.8 0.8 0.9 0.8 0.8 0.8 0.8 0.9
Warmup runs: 0.8

Current
Mean: 0.8 ms
Stdev: 0.1 ms (6.3%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.8 0.9 0.8 0.8 1.0
Warmup runs: 0.8
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Other Component 1 🔴 -
Other Component 20 run 1 🔴 -
Async Component 1 🔴 -

Added Entries

There are no entries

Removed Entries

There are no entries

Generated by 🚫 dangerJS against e884709

@mdjastrzebski mdjastrzebski merged commit 780f4f3 into main Oct 28, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the refactor/min-threshold-calculation branch October 28, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant