Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape test runner path #544

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: escape test runner path #544

merged 2 commits into from
Nov 27, 2024

Conversation

mdjastrzebski
Copy link
Member

Summary

Fixes #543

Test plan

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 05618da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/reassure-cli Patch
reassure Patch
@callstack/reassure-compare Patch
@callstack/reassure-danger Patch
@callstack/reassure-logger Patch
@callstack/reassure-measure Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Performance Comparison Report

  • Current: HEAD (c118f1f) - 2024-11-27 10:46:01Z
  • Baseline: main (6b867a2) - 2024-11-27 10:45:16Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 84.3 ms → 82.7 ms (-1.6 ms, -1.9%) 7 → 7
fib 30 function 38.6 ms → 39.0 ms (+0.3 ms, +0.8%) 1 → 1
fib 31 function 63.1 ms → 62.8 ms (-0.3 ms, ±0.0%) 1 → 1
fib 32 function 101.7 ms → 102.1 ms (+0.4 ms, ±0.0%) 1 → 1
InitialRenders 1 render 1.2 ms → 1.1 ms (-0.0 ms, -3.4%) 2 → 2
InitialRenders 3 render 1.3 ms → 1.2 ms (-0.1 ms, -4.5%) 4 → 4
ManyRenderIssues render 1.4 ms → 1.4 ms (-0.0 ms, -1.8%) 5 → 5
Other Component render 52.5 ms → 52.0 ms (-0.4 ms, -0.8%) 4 → 4
Other Component 20 run render 53.0 ms → 53.4 ms (+0.4 ms, +0.7%) 4 → 4
RedundantUpdates render 0.9 ms → 0.8 ms (-0.0 ms, -3.9%) 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 84.3 ms
Stdev: 0.7 ms (0.8%)
Runs: 82.8 84.4 83.5 85.1 84.4 84.5 84.6 85.0 83.7 84.6
Warmup runs: 84.4

Current
Mean: 82.7 ms
Stdev: 0.7 ms (0.9%)
Runs: 81.8 83.6 83.0 82.7 82.4 82.2 82.3 84.1 82.4 82.2
Warmup runs: 87.1
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 38.6 ms
Stdev: 0.9 ms (2.4%)
Runs: 38.7 39.0 38.9 39.0 36.0 38.9 38.9 38.9 39.0 38.9
Warmup runs: 39.3

Current
Mean: 39.0 ms
Stdev: 0.1 ms (0.2%)
Runs: 38.8 38.9 39.2 38.9 39.0 38.9 38.9 38.9 39.0 39.0
Warmup runs: 38.8
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 63.1 ms
Stdev: 1.0 ms (1.6%)
Runs: 62.8 62.8 62.9 62.8 66.0 62.8 62.7 62.8 62.8 62.8
Warmup runs: 62.4

Current
Mean: 62.8 ms
Stdev: 0.1 ms (0.2%)
Runs: 62.8 62.8 62.8 62.8 62.8 62.8 63.1 62.7 62.8 62.8
Warmup runs: 62.6
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 101.7 ms
Stdev: 2.1 ms (2.0%)
Runs: 101.9 102.1 101.9 102.0 102.1 105.1 101.9 102.0 101.9 96.6
Warmup runs: 101.9

Current
Mean: 102.1 ms
Stdev: 0.8 ms (0.8%)
Runs: 101.6 101.6 101.9 101.9 102.0 102.0 104.4 102.0 102.0 101.9
Warmup runs: 101.7
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 1.2 ms
Stdev: 0.2 ms (16.8%)
Runs: 1.5 1.4 1.1 1.3 1.1 0.9 1.1 1.1 0.9 1.2
Warmup runs: 131.4

Current
Mean: 1.1 ms
Stdev: 0.2 ms (16.0%)
Runs: 1.4 1.4 1.1 1.2 1.1 0.8 1.2 1.0 0.9 1.1
Warmup runs: 9.3
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.3 ms
Stdev: 0.1 ms (7.3%)
Runs: 1.3 1.4 1.2 1.2 1.2 1.2 1.2 1.4 1.3 1.3
Warmup runs: 1.3

Current
Mean: 1.2 ms
Stdev: 0.0 ms (4.0%)
Runs: 1.2 1.3 1.2 1.2 1.2 1.1 1.2 1.2 1.2 1.2
Warmup runs: 1.3
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.4 ms
Stdev: 0.0 ms (1.5%)
Runs: 1.5 1.4 1.4 1.4 1.4 1.4 1.4 1.4 1.4 1.4
Warmup runs: 1.4

Current
Mean: 1.4 ms
Stdev: 0.0 ms (1.9%)
Runs: 1.4 1.4 1.4 1.4 1.4 1.4 1.3 1.4 1.4 1.3
Warmup runs: 1.4
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Other Component render Baseline
Mean: 52.5 ms
Stdev: 0.5 ms (1.0%)
Runs: 52.4 54.0 52.1 52.3 52.5 52.3 52.2 52.3 52.2 52.4
Warmup runs: 60.1

Current
Mean: 52.0 ms
Stdev: 0.3 ms (0.6%)
Runs: 51.3 52.1 51.9 52.2 52.2 52.1 52.4 52.2 51.7 52.2
Warmup runs: 54.9
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 run render Baseline
Mean: 53.0 ms
Stdev: 0.8 ms (1.5%)
Runs: 52.1 52.6 53.2 52.4 53.3 52.5 52.7 52.8 53.3 53.5 52.4 55.6 54.2 53.5 52.9 52.7 52.6 52.6 52.7 52.5
Warmup runs: 52.3

Current
Mean: 53.4 ms
Stdev: 3.4 ms (6.4%)
Runs: 52.8 52.9 51.8 52.8 52.5 67.5 52.3 52.7 52.5 54.7 51.9 52.3 51.6 52.9 52.3 52.5 52.3 52.4 52.1 55.3
Warmup runs: 52.1
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
RedundantUpdates render Baseline
Mean: 0.9 ms
Stdev: 0.0 ms (4.3%)
Runs: 0.9 0.9 0.9 0.9 0.9 0.9 0.8 0.8 0.8 0.9
Warmup runs: 0.8

Current
Mean: 0.8 ms
Stdev: 0.0 ms (4.6%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.9 0.9 0.8 0.8 0.9
Warmup runs: 0.8
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Other Component 1 🔴 -
Other Component 20 run 1 🔴 -
Async Component 1 🔴 -

Added Entries

There are no entries

Removed Entries

There are no entries

Generated by 🚫 dangerJS against 05618da

@mdjastrzebski mdjastrzebski merged commit aa608ae into main Nov 27, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the fix/path-with-space branch November 27, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reassure command fails when the testRunnerPath has a space in it
1 participant