Multiple Configuration Support #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data type associated to the property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered an issue around having multiple Meganav Data Types being used on a single Umbraco site. We have one data type restricted to single items, and a second data type which allows an number of items. Once the site loads, the first configuration fetched by Meganev was the one used for all future renders. This means if the single item config was fetched first, our navigation menus with multiple items would only display the first item in the list.
This change updates the EnsureConfiguration method. We store a dictionary of configuration IDs to configuration objects, and return the proper one to the calling method based on the configuration needed by the property type.