-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added dark mode support #163
base: master
Are you sure you want to change the base?
Conversation
I would love to bump this. 👍 Also, @jaireth what would your thoughts be on the ability to switch themes based on body class as well? Then we could make a toggle button for those who arent using MacOS dark mode? |
@callumlocke Thoughts? Dark color scheme has been a very popular request for a long period of time—and seems pretty important to accessibility: I know lots of eyes will be grateful! |
🥇 👍 💯 |
i have no idea why this isn't merged yet. thank you, this is great |
I believe that it could have a small toolbar for configuring those options (Theme, Tabs, Font size, etc). |
Do it, please! |
Is there a forked version of this extension that includes this PR ? |
@medilies I switched to https://github.com/tulios/json-viewer a long time ago and find it both more usable and aesthetic (lots of light and dark themes). |
Why isn't this merged yet???? |
Added support for dark mode. I used Dark Readers styles to add a "@media (prefers-color-scheme: dark)" section to the content css. I made the change in content.scss and brought them over to content.css and the content.js file.