Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dark mode support #163

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added dark mode support #163

wants to merge 3 commits into from

Conversation

jaireth
Copy link

@jaireth jaireth commented May 16, 2020

Added support for dark mode. I used Dark Readers styles to add a "@media (prefers-color-scheme: dark)" section to the content css. I made the change in content.scss and brought them over to content.css and the content.js file.

@jaireth jaireth mentioned this pull request May 16, 2020
@austinbenerdy
Copy link

I would love to bump this. 👍

Also, @jaireth what would your thoughts be on the ability to switch themes based on body class as well? Then we could make a toggle button for those who arent using MacOS dark mode?

@Huy-Ngo
Copy link

Huy-Ngo commented Jul 15, 2020

Wow, this is nice, but I agree that it would be nicer to have a toggle button. Btw I think issues #141 #148 #87 should be resolved by this PR.

@jsejcksn
Copy link

@callumlocke Thoughts?

Dark color scheme has been a very popular request for a long period of time—and seems pretty important to accessibility: I know lots of eyes will be grateful!

@shobhitagarwal1612
Copy link

🥇 👍 💯

@boop5
Copy link

boop5 commented Jun 13, 2021

i have no idea why this isn't merged yet. thank you, this is great

@rafaell-lycan
Copy link

I believe that it could have a small toolbar for configuring those options (Theme, Tabs, Font size, etc).

@Saltallica
Copy link

Do it, please!

@medilies
Copy link

Is there a forked version of this extension that includes this PR ?

@jsejcksn
Copy link

Is there a forked version of this extension that includes this PR ?

@medilies I switched to https://github.com/tulios/json-viewer a long time ago and find it both more usable and aesthetic (lots of light and dark themes).

@BigeYoung BigeYoung mentioned this pull request May 23, 2022
@uvlad7
Copy link

uvlad7 commented Jun 6, 2022

Is there a forked version of this extension that includes this PR ?

@medilies Yes, it is here, update with this feature will be available soon.

@BrammyS
Copy link

BrammyS commented Jun 10, 2022

Why isn't this merged yet????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.