Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions being wrongly shared across requests in tests #117

Open
calpaterson opened this issue Apr 25, 2024 · 0 comments
Open

Transactions being wrongly shared across requests in tests #117

calpaterson opened this issue Apr 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@calpaterson
Copy link
Owner

Description

Somewhere along the line, something has gone wrong and the session lifetime in tests not crosses multiple requests

Steps to reproduce

  1. Find a test that POSTs something and then GETs it
  2. Remove the sesh.commit() from the relevant system code

Expected result

Test fails

Actual result

Test passes

Additional details

csvbase/csvbase/web/main/bp.py

Line 1199 in 67ed93c

sesh.commit()
is a good candidate, when run in conjunction with the registration tests
@calpaterson calpaterson added the bug Something isn't working label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@calpaterson