generated from caltechlibrary/py-cli-template
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for release and fix community versions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former-commit-id: 83c523cc6f7dd83164a40ad6b9609b51cc5a1c84
Former-commit-id: 9232115f5886d2029642d1859111fdfbf98111d1
Former-commit-id: 50ea5c97f80dc596eab4b7bb1abc1a10fdc5ec20
Former-commit-id: c90e4bb67ff8d19c756a200f66047fd61994aa6b
Former-commit-id: 005cc25355fc717a48af3396afccef335d5d4f43
Former-commit-id: 856f7d1f33008bfa648d6de6e439ac1c1927592a
Former-commit-id: e788d014251474a02e6074a72a74f33da5d548b0
Former-commit-id: 7461e88b5109e2bb082ff6cac3349d638d3853c5
Former-commit-id: d15303f8071cc736e16ed3824d5c1fe449d16df1
Former-commit-id: 95c72d94bcb96a81ea8a88ad8110cdaaa30907a6
Former-commit-id: 55327b456d4de0f55cd33d3fe7bdc8cf6b69e52c
Former-commit-id: 96543211e00a5bc0de62957e92a1ff15903e7880
Former-commit-id: acd383da1f01c0455346c3451635e87f9d15f322
Former-commit-id: ab16b909f02bdae9fc3b3cf410b04569c5971769
Gleaned from Wikipedia and other sources.
`invenio_server_name(...)` tries to get the name of the server by getting the first record and looking in the field metadata.publisher in that record. It turns out our test server doesn't have a `publisher` field in that record, so the function failed. The new code falls back to using the host name as the server name if it can't get a `publisher` field value.
Decided that the name "software release archiver", while being more descriptive, was also a bit too ambiguous. Going back to the original name.
I forgot to make the same edits as in sample-workflow.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the main branch and includes one additional fix. Currently community records are always sent to the community review process, but community review is only needed for the main record (not versions). A user found this bug, so please let me know when the new version is available.