Take up to 11 characters of field name from DBF #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBF file structure allows up to 11 characters/bytes in the field name (http://en.wikipedia.org/wiki/.dbf#File_Architecture_Overview), while ShapeFile spec sets the limit to 10 (http://en.wikipedia.org/wiki/Shapefile ) within the same DBF. This change allows reading longer field names. Writing such files could be seen as producing non-standard compliant, but reading them does no harm (null characters are stripped out anyway). We're using this on http://raba.openstreetmap.si since openstreetmap-si/raba.openstreetmap.si@b72c357 (dbf files within shapefile zips were adjusted with [bbe](http://linux.die.net/man/1/bbe) to insert an extra character)
|
a test would be great do I don't accidentally revert it |
|
Added that, and an extra tests so that you don't break it for us. :) |
stefanb
referenced
this pull request
in openstreetmap-si/raba.openstreetmap.si
Apr 25, 2015
…sets the limit to 10
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBF file structure allows up to 11 characters/bytes in the field name (http://en.wikipedia.org/wiki/.dbf#File_Architecture_Overview), while ShapeFile spec sets the limit to 10 (http://en.wikipedia.org/wiki/Shapefile ) within the same DBF.
This change allows reading longer field names. Writing such files could be seen as producing non-standard compliant, but reading them does no harm (null characters are stripped out anyway).
We're using this on http://raba.openstreetmap.si since
openstreetmap-si/raba.openstreetmap.si@b72c357
(dbf files within shapefile zips were adjusted with bbe to insert an extra character)