support for 850 code page #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
this is somewhat intentional as textdecoder is included in most browsers already while iconv-lite is still pretty heavy, what exactly is in the cpg file and is there an alias that also works (e.g. latin-1 is that the same ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just want parseDBF to support some code pages, such as 850, which is sometimes used in some shapefiles. On server side of the master, 850 code page is supported by 'iconv-lite'. On the other hand, 'TextDecoder' running on client side, doesn't support it. Fortunately, 'iconv-lite' supports to run on the browser now by using Browserify. That's why I just delete the browser field in package.json.