Changes from PR comments

calyxir · Dec 6, 2024 · c14dcd2 · c14dcd2
1 parent 7bf15fa
commit c14dcd2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 33 deletions.
diff --git a/docs/running-calyx/profiler.md b/docs/running-calyx/profiler.md
@@ -8,7 +8,7 @@ Profilers can help you analyze performance information to find places you can op
 
 In order to run the profiler, you need:
 - [fud2][]
-- The Python `vcdvcd` library
+- The Python [`vcdvcd` library](https://github.com/cirosantilli/vcdvcd). Most likely you can download it by running `python -m pip install --user vcdvcd`.
 - A clone of Brendan Gregg's Flamegraph repository: [https://github.com/brendangregg/FlameGraph](https://github.com/brendangregg/FlameGraph)
 
 Then, you need to edit your fud2 configuration file to specify the location of `flamegraph.pl` within the `Flamegraph` repository:

diff --git a/tools/profiler/create-visuals.sh b/tools/profiler/create-visuals.sh
@@ -21,7 +21,7 @@ for folded in $( ls ${DATA_DIR}/*.folded ); do
     base_name=$( echo "${folded}" | rev | cut -d. -f2- | rev )
     if [[ "${base_name}" == *"scaled"* ]]; then
 	${FLAME_GRAPH_SCRIPT} --countname="cycles" ${folded} > ${base_name}-original.svg
-	python3 ${SCRIPT_DIR}/finagle-with-svg.py ${base_name}-original.svg > ${base_name}.svg
+	python3 ${SCRIPT_DIR}/adjust-scaled-flame-svg.py ${base_name}-original.svg > ${base_name}.svg
     else
         ${FLAME_GRAPH_SCRIPT} --countname="cycles" ${folded} > ${base_name}.svg
     fi

diff --git a/tools/profiler/finagle-with-svg.py b/tools/profiler/finagle-with-svg.py