-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eDSL: no cells
list when defining new component
#2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Awesome! This also brings it in line with the interface of the Rust-based builder which only allows construction of cells on a particular component. |
Super. I'll just leave this PR open in case @sampsyo, @EclecticGriffin, or @calebmkim know of a good reason to keep this feature around! |
No objections here! |
jiahanxie353
pushed a commit
to jiahanxie353/calyx
that referenced
this pull request
May 29, 2024
* Neaten mul_group * Neaten another helper * A little more neatening * Less use of Cell * Reduce manual imports * Catch up to main * Stray doctring issue * No cells when defining component * More thoroughly remove the power to init a component with list of cells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #2034 shows, it is possible to create a free-floating list of
cells
prior to the creation of a component, and to then associate those cells with a component when creating the component.This is a little dicey and inelegant. This PR removes that power. You must now create a component, and then construct and insert cells specifically into that component.
This change has no victims in the existing codebase, since NTT (the only user of this feature) has stopped using it as of #2034.
If someone really wanted to, say, insert some "basic" cells into a variety of components and then add more stuff per component, like so:
They can still do that: