[Profiling] Use TDCC group's go to infer first state's start time
#2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… arm should not be counted
…is not actually a part of the par
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains small revisions to profiling:
gosignal in order to infer when the FSM is technically "starting".To describe a bit more about (2) - I previously had a bug where
readfromlanguage-tutorial-iterate.futilwas "active" for ~60 cycles (when it should only be active for 16). This was becausereadcorresponds to the 0th state of the FSM of the par arm containingread,write, andupd, and the 0th state corresponds to both the first group and a reset state. To fix this, I used thegosignal for the TDCC group that manages the FSM to figure out when the first group is active.