Generating calyx files as text via Rust too! #2157
Conversation
|
TODO: add more of the niceties of the eDSL, like helpers for common groups. |
|
Super cool! Sadly I'm the wrong person to review this for you, since I speak no Rust (yet) and am a little too busy to learn via your PR. Thanks for this work, and I hope someone will give this a look soon! |
tools/calyx-writer/lib.rs
Outdated
| Rc::new(RefCell::new(value)) | ||
| } | ||
|
|
||
| struct IndentFormatter<'a, 'b: 'a> { |
There was a problem hiding this comment.
I'm not convinced you need two distinct lifetimes here. Is there a particular
part of code that doesn't work if you just have the one?
There was a problem hiding this comment.
my intuition is that you should be able to have &'a mut fmt::Formatter<'a> but if not don't worry about it. I'd have to poke the code directly, which we could do together if desired but I could be wrong here
There was a problem hiding this comment.
Yeah I tried that and got this error :(
tools/calyx-writer/lib.rs
Outdated
|
|
||
| /// Constructs a new cell named `name` that instatiates `inst` with | ||
| /// arguments `args`. | ||
| pub fn cell<S: ToString, T: ToString>( |
There was a problem hiding this comment.
Recommend using a where construct here for readability
There was a problem hiding this comment.
You could also use more descriptive generic names if desired
|
Thanks for the extensive review! I'll get to implementing these changes, and I left a few clarifying questions on some of your comments. |
| for output in [Port::new_in_comp("done", 1) | ||
| .with_attribute(Attribute::num("done", 1))] | ||
| { | ||
| new_self.outputs.push(output); | ||
| } |
There was a problem hiding this comment.
I don't see why this needs to be a for loop.
There was a problem hiding this comment.
In case there are other special output ports needed later?
|
@EclecticGriffin anything pressing to be resolved? |
|
LGTM modulo the one note I left. Merge when ready |
The Python eDSL is useful for generating and emitting calyx designs as text. I wrote a rust library that achieves the same goals. Here's an example of my initial attempt at creating it in usage. You can even encode comments!
I hacked this together in a few hours, and it's missing a lot of features (such as
invokes), but it supports a very large subset of calyx right now.