Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser #2353
Parser #2353
Changes from 6 commits
28d9af4
17fed18
4654907
8931373
1de68c6
760bb01
adfadb1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend making this a standard accessor which returns a reference to the vec
or a slice and cloning externally when necessary
Check failure on line 321 in interp/src/debugger/commands/core.rs
GitHub Actions / Check Formatting
Check failure on line 321 in interp/src/debugger/commands/core.rs
GitHub Actions / Check Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As clippy points out, there is a trait called
FromIterator
which you should move this implementation into.See: https://doc.rust-lang.org/std/iter/trait.FromIterator.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo
Check failure on line 5 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 5 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 6 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 6 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 63 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 63 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 63 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
Check failure on line 63 in interp/src/debugger/commands/path_parser.rs
GitHub Actions / Check Formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
#[allow(dead_code)]
here for the moment since this PR doesn't use thefunction. This will quiet clippy down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the size issue change the return type to
Box<Error<Rule>>
and add.map_err(Box::new)
to the final line