Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cider Dap - Variables displaying #2357

Merged
merged 26 commits into from
Dec 11, 2024
Merged

Cider Dap - Variables displaying #2357

merged 26 commits into from
Dec 11, 2024

Conversation

smd21
Copy link
Contributor

@smd21 smd21 commented Nov 19, 2024

bad branch name (oops)
This branch adds the following functionality to the VSCode Cider debugger:

  1. Displaying accurate port values
  2. Continue requests now behave according to the spec by informing VSCode why the debugger was stopped
  3. Cells (scopes) displayed now only shows the cells for the current component, rather then every cell in the environment
  4. Small json tweaks (name, publisher, etc)

Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting! Left some notes, on a bunch of things. Please request a re-review when you're ready

cider-dap/src/main.rs Outdated Show resolved Hide resolved
cider-dap/src/main.rs Outdated Show resolved Hide resolved
cider-dap/src/main.rs Outdated Show resolved Hide resolved
interp/src/debugger/debugger_core.rs Outdated Show resolved Hide resolved
interp/src/debugger/debugger_core.rs Outdated Show resolved Hide resolved
interp/src/debugger/debugger_core.rs Show resolved Hide resolved
cider-dap/src/adapter.rs Outdated Show resolved Hide resolved
cider-dap/src/adapter.rs Outdated Show resolved Hide resolved
cider-dap/src/adapter.rs Outdated Show resolved Hide resolved
cider-dap/src/adapter.rs Outdated Show resolved Hide resolved
@EclecticGriffin
Copy link
Collaborator

@smd21 The CI stuff should be resolved now, so merge the main branch into this one and assuming there are no issues, let's get this merged

@smd21 smd21 merged commit 3057347 into main Dec 11, 2024
18 checks passed
@smd21 smd21 deleted the cider-dap-continue branch December 11, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants