Remove rust-toolchain.toml
#2369
Conversation
|
Apologies, that's my fault. Strangely, I passed CI on my branch, but failed on main; I didn't know there was a difference between those CI checks. I think the problem was that I forgot to remove line I'm neutral on whether it should be removed; fine with either call |
|
in #2365 I removed the root of the issue with a temporary hack. Not sure if we should just straight up enforce the Rust version. |
|
I think it is worth keeping the toolchain toml and just fixing the line that overrides it. It's better for us to mandate a version of rust for the CI rather than have the periodic breakage when a new lint or check gets introduced, since that makes things pretty brittle and causes a fair bit of chaos. |
|
This particular cycle of CI breakage is by no means the first time this has happened and is arguably attributable to not standardizing a single rust version for all of CI |
|
ok |
Supersedes #2369. `rust-toolchain.toml` now determines the version of rust used for every aspect of the CI, rather than having it change on its own or be set separately. As it turns out, the version of rust used for the clippy lints was also pinned separately, so I also had to address all those lints. As a result, I had to make minor changes to a bunch of code, the vast majority of which were either docstring indents or places where people manually implemented `ToString` instead of using `Display`. I don't anticipate any of these changes messing with things but if I did break something, do let me know. Assuming I've done things correctly, it should be the case that the rust version will not change on its own anymore, and we can update the version used by all of Ci by editing the toolchain file
|
Closed in favor of #2374 |
Since #2364, which added
rust-toolchain.toml, still had failing tests on main (https://github.com/calyxir/calyx/actions/runs/12151446330/job/33886064698), I don't think this is needed?