-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiler] Profiling support for parallel programs #2370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…themselves are activE
…vide scaled flame graphs by 1000
ekiwi
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes and then we can merge this in.
ekiwi
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
@ayakayorihiro : is this ready to be merged?
Merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
profiler-instrumentation
pass is now updated to contain four types of probes in order to capture call site information.group_probe
: A probe that is high when a group is active.primitive_probe
: A probe that is high when a primitive cell is active.se_probe
: A probe that is high when a group that structurally enables another group is active.cell_probe
: A probe that is high when a group that invokes a non-primitive cell is active.profiler-process.py
: an updated VCD postprocessing script that generates.folded
and.dot
files:aggregate.dot
: A tree summary of the execution of the program. Nodes (groups and cells) are labeled with the number of times the node was a leaf, and edges are labeled with the number of cycles that edge was activated.rank{i}.dot
: A tree representation of thei
th most active stack picture.rankings.csv
lists the specific cycles that each ranked tree was active for.fud2/scripts/profiler.rhai
).folded
and.dot
files into visualizations (svg
andpng
files respectively)As usual, I'd really appreciate any suggestions or thoughts!!