Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fud2] AXI wrapper script cleanup & unified python names #2384

Merged
merged 9 commits into from
Dec 31, 2024

Conversation

nathanielnrn
Copy link
Contributor

@nathanielnrn nathanielnrn commented Dec 30, 2024

The WIP PR that tries to get an yxi powered end to end xilinx tools workflow up and running ballooned into a beast and has gotten pretty stale. This is me trying to break things down into parts and slowly get everything merged.

This changes the *axi_generator.py files to use underscores, which is needed for proper importing afaict.
Also snuck in formatting changes to dynamic_axi_generator.py.

These are pretty minor changes so going to merge when tests pass.

This ensures output calyx files are valid (otherwise we might pass in
concrete cells to non-ref cells). Also sticking with the more complex
sed which removes everything until the first `component main` line,
as opposed to just removing `^import` lines to avoid polluting files with
`external` blocks
@nathanielnrn nathanielnrn merged commit 5e8ff91 into main Dec 31, 2024
18 checks passed
@nathanielnrn nathanielnrn deleted the axi-wrapping-relative-path-fix branch December 31, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant