Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Release r2.1 #290

Merged
merged 28 commits into from
Feb 5, 2025
Merged

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jan 23, 2025

What type of PR is this?

  • subproject management

What this PR does / why we need it:

Prepare the public pre-release r2.1

Additional Information

This PR will also includes:
fix #293
fix #294

@maxl2287 maxl2287 changed the title Prepare release r2.1 Release r2.1 Jan 23, 2025
@maxl2287 maxl2287 changed the title Release r2.1 Pre-Release r2.1 Jan 23, 2025
@maxl2287 maxl2287 self-assigned this Jan 23, 2025
@maxl2287 maxl2287 marked this pull request as ready for review January 23, 2025 21:31
@maxl2287 maxl2287 requested review from hdamker and a team and removed request for a team January 23, 2025 21:31
CHANGELOG.md Outdated Show resolved Hide resolved
…ness-Checklist.md & geofencing-subscriptions-API-Readiness-Checklist.md
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to update the root README as well with the links to the latest pre-release (please double check):

* The latest pre-release is [r2.1](https://github.com/camaraproject/DeviceLocation/tree/r2.1) with the following API definitions (with inline documentation):
  - **location-verification v2.0.0-rc.1** [[YAML OAS]](https://github.com/camaraproject/DeviceLocation/blob/r2.1/code/API_definitions/location-verification.yaml) [[View it on ReDoc]](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/DeviceLocation/r2.1/code/API_definitions/location-verification.yaml&nocors) [[View it on Swagger Editor]](https://editor.swagger.io/?url=https://raw.githubusercontent.com/camaraproject/DeviceLocation/r2.1/code/API_definitions/location-verification.yaml)
  - **location-retrieval v0.4.0-rc.1** [[YAML OAS]](https://github.com/camaraproject/DeviceLocation/blob/r2.1/code/API_definitions/location-retrieval.yaml) [[View it on ReDoc]](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/DeviceLocation/r2.1/code/API_definitions/location-retrieval.yaml&nocors) [[View it on Swagger Editor]](https://editor.swagger.io/?url=https://raw.githubusercontent.com/camaraproject/DeviceLocation/r2.1/code/API_definitions/location-retrieval.yaml)
  - **geofencing-subscriptions v0.4.0-rc.1** [[YAML OAS]](https://github.com/camaraproject/DeviceLocation/blob/r2.1/code/API_definitions/geofencing-subscriptions.yaml) [[View it on ReDoc]](https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/camaraproject/DeviceLocation/r2.1/code/API_definitions/geofencing-subscriptions.yaml&nocors) [[View it on Swagger Editor]](https://editor.swagger.io/?url=https://raw.githubusercontent.com/camaraproject/DeviceLocation/r2.1/code/API_definitions/geofencing-subscriptions.yaml)

jlurien
jlurien previously approved these changes Jan 24, 2025
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287 maxl2287 dismissed jlurien’s stale review January 24, 2025 14:21

The merge-base changed after approval.

@maxl2287 maxl2287 requested a review from a team February 3, 2025 08:52
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 requested review from a team and bigludo7 February 3, 2025 13:29
bigludo7
bigludo7 previously approved these changes Feb 3, 2025
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 requested a review from a team February 3, 2025 13:30
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hdamker
Copy link
Contributor

hdamker commented Feb 4, 2025

From Release Management perspective there is one mandatory fix in the CHANGELOG.md to be done (r1.2 information edited instead of r2.1 in two lines), plus some suggestions.

Beyond that the "# Authorization and Authentication" section in a all three YAML files should be replaced with the final text from ICM r2.2.

Co-authored-by: Herbert Damker <[email protected]>
README.md Outdated Show resolved Hide resolved
@maxl2287 maxl2287 requested a review from hdamker February 4, 2025 14:23
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good from Release Management perspective!

@maxl2287 maxl2287 requested review from bigludo7 and jlurien February 4, 2025 21:07
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @maxl2287 !

@maxl2287 maxl2287 merged commit 558d821 into camaraproject:main Feb 5, 2025
2 checks passed
@maxl2287 maxl2287 deleted the prepare-release-r2.1 branch February 5, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated message field and description for Error 429 Allow zero-length strings in x-correlator header
4 participants