Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KYC-Fill-In examples for consent collection, access token requests and API use #177

Conversation

AxelNennker
Copy link
Collaborator

What type of PR is this?

  • documentation

What this PR does / why we need it:

This PR shows:

  • how user consent can be requested using OIDC authorization code flow
  • the use of kyc-fill-in:set-all when requesting an OIDC code
  • explains that the subject identifier for the API is associated with the access token
  • explains that the scopes for the API is associated with the access token

No extra phoneNumber request parameter is needed when using 3-legged / front-end flow.
Using an extra phoneNumber parameter in the API request should be restricted to 2-legged flow.

@ToshiWakayama-KDDI
Copy link
Collaborator

Hi @AxelNennker ,

Thanks. It seems to me that the added parts are explaining OIDC Authorisation flow and examples, so, there is no reason to object it. However, I have not seen this kind of OIDC flow explanation in other APIs, so, it may be better to discuss and approve first in Commonalities or ICM, not KYC. Concerned a bit.

WDYT, all?

Best regards,
Toshi

@GillesInnov35
Copy link
Collaborator

hi @AxelNennker , @ToshiWakayama-KDDI , I think. that what is added in the yaml is more a Getting Started which show be exposed on the exposition gateway than a specifications.
I don't think it should be added in my opinion.

Gilles

@ToshiWakayama-KDDI
Copy link
Collaborator

Thanks, @GillesInnov35 . I agree with you. So, we can close this PR, can't we? Or, if we need furthre discussion at least, we can conclude no impact to KYC Fill-in Spring25 Meta.

Thanks,
Toshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants