-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring25 - M3 Milestone - Prepare r2.1 #183
Spring25 - M3 Milestone - Prepare r2.1 #183
Conversation
Hello @fernandopradocabrillo We have just to add within x-correlator definition. probably easier to do this in this PR... |
I did it directly in your PR - Hope it works :) |
@bigludo7: Do the header definitions in line 197 (SimSwap) and 333 (SimSwapSubscriptions) also need the pattern? |
The version within the test definition .feature files is already 2.0.0. The following
does not fit with:
Or in other words: the version related lines in the .feature files should be also touched here in the release PR. |
The "# Authorization and authentication" section has been slightly reworded between ICM r2.1 and r2.2, you want to take the latest version if the release is done before yours ;-) |
You might want to mention the addition of the x-correlator pattern in the CHANGELOG.md update. |
documentation/API_documentation/sim-swap-subscriptions-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from Release Management perspective - I could approve already, but maybe you will have a second look if you are already fulfilling the r2.2 of Commonalities and ICM.
| 2 | Design guidelines from Commonalities applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/Commonalities/releases/tag/r2.1) | | ||
| 3 | Guidelines from ICM applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/IdentityAndConsentManagement/releases/tag/r2.1) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything missing from the Commonalities and ICM r2.2 changes (error responses are looking good, x-correlator updated, ...)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are fully aligned. I'll change the version
| 2 | Design guidelines from Commonalities applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/Commonalities/releases/tag/r2.1) | | ||
| 3 | Guidelines from ICM applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/IdentityAndConsentManagement/releases/tag/r2.1) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything missing from the Commonalities and ICM r2.2 changes (error responses are looking good, x-correlator updated, ...)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
@fernandopradocabrillo @bigludo7 Can you check the remaining suggestions and questions which I had about 2 weeks ago to get this PR done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from Release Management perspective - thanks @fernandopradocabrillo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Fernando
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Complete preparations for first pre-release of Sim Swap and Sim Swap Subscriptions APIs for meta Spring25