Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring25 - M3 Milestone - Prepare r2.1 #183

Merged

Conversation

fernandopradocabrillo
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo commented Jan 21, 2025

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Complete preparations for first pre-release of Sim Swap and Sim Swap Subscriptions APIs for meta Spring25

@bigludo7
Copy link
Collaborator

Hello @fernandopradocabrillo
A small fix required: add a pattern for x-correlator allowing zero-length strings.
see: camaraproject/Commonalities#387

We have just to add
pattern: ^[a-zA-Z0-9-]{0,55}$

within x-correlator definition.

probably easier to do this in this PR...

@bigludo7
Copy link
Collaborator

I did it directly in your PR - Hope it works :)

@hdamker
Copy link
Collaborator

hdamker commented Jan 27, 2025

I did it directly in your PR - Hope it works :)

@bigludo7: Do the header definitions in line 197 (SimSwap) and 333 (SimSwapSubscriptions) also need the pattern?

@fernandopradocabrillo
Copy link
Collaborator Author

I did it directly in your PR - Hope it works :)

@bigludo7: Do the header definitions in line 197 (SimSwap) and 333 (SimSwapSubscriptions) also need the pattern?

@bigludo7 @hdamker
I think we need it in both parameters and headers:
image

@hdamker
Copy link
Collaborator

hdamker commented Jan 28, 2025

The version within the test definition .feature files is already 2.0.0. The following

  Background: Common checkSimSwap setup
    Given the resource "sim-swap/v2/check"

does not fit with:

servers:
  - url: "{apiRoot}/sim-swap/v2rc1"

Or in other words: the version related lines in the .feature files should be also touched here in the release PR.

@hdamker
Copy link
Collaborator

hdamker commented Jan 28, 2025

The "# Authorization and authentication" section has been slightly reworded between ICM r2.1 and r2.2, you want to take the latest version if the release is done before yours ;-)

@hdamker
Copy link
Collaborator

hdamker commented Jan 28, 2025

I did it directly in your PR - Hope it works :)

You might want to mention the addition of the x-correlator pattern in the CHANGELOG.md update.

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Release Management perspective - I could approve already, but maybe you will have a second look if you are already fulfilling the r2.2 of Commonalities and ICM.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines 8 to 9
| 2 | Design guidelines from Commonalities applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/Commonalities/releases/tag/r2.1) |
| 3 | Guidelines from ICM applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/IdentityAndConsentManagement/releases/tag/r2.1) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything missing from the Commonalities and ICM r2.2 changes (error responses are looking good, x-correlator updated, ...)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are fully aligned. I'll change the version

Comment on lines 8 to 9
| 2 | Design guidelines from Commonalities applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/Commonalities/releases/tag/r2.1) |
| 3 | Guidelines from ICM applied | O | M | M | M | Y | [r2.1](https://github.com/camaraproject/IdentityAndConsentManagement/releases/tag/r2.1) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything missing from the Commonalities and ICM r2.2 changes (error responses are looking good, x-correlator updated, ...)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@hdamker
Copy link
Collaborator

hdamker commented Feb 10, 2025

@fernandopradocabrillo @bigludo7 Can you check the remaining suggestions and questions which I had about 2 weeks ago to get this PR done?

Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Release Management perspective - thanks @fernandopradocabrillo

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks Fernando

@fernandopradocabrillo fernandopradocabrillo merged commit 5268c30 into camaraproject:main Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spring25 Spring25 release preparation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants