Merge pull request #78 from cambrian-mllm/hotfix-9-19

hotfix: rm comments
cambrian-mllm · Sep 19, 2024 · 78b9708 · 78b9708
2 parents 8957657 + fefd602
commit 78b9708
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 37 deletions.
diff --git a/eval/eval/seed/seed_eval.py b/eval/eval/seed/seed_eval.py
@@ -145,39 +145,3 @@ def eval_model(args):
     args = parser.parse_args()
 
     eval_model(args)
-
-
-
-""""
-python eval/mmbench_en/mmbench_en_eval.py \
-    --model_path $CKPT_DIR/llava-TPU-llava-v1.5-7b-finetune-6993k \
-    --answers_file ./test_1.jsonl \
-    --question_extension "Please answer the question, provide your final answer as the last word of the response"
-
-    
-python eval/mmbench_en/mmbench_en_eval.py \
-    --model_path $CKPT_DIR/llava-TPU-llava-v1.5-7b-finetune-6993k \
-    --answers_file ./test_2.jsonl \
-    --question_extension "Please answer the question, provide your final answer in the end of your response with Answer: {your answer}."
-
-python eval/mmbench_en/mmbench_en_eval.py \
-    --model_path $CKPT_DIR/llava-TPU-llava-v1.5-7b-finetune-6993k \
-    --answers_file ./test_3.jsonl \
-    --question_extension "Please answer the question, provide your final answer at the very end. You must respond in the following format: '{explaination} Answer: {your answer}'"
-
-
-python eval/mmbench_en/mmbench_en_eval.py \
-    --model_path $CKPT_DIR/llava-TPU-llava-v1.5-7b-finetune-6993k \
-    --answers_file ./test_5.jsonl \
-    --question_extension "\n"
-
-python eval/mmbench_en/mmbench_en_eval.py \
-    --model_path $CKPT_DIR/llava-TPU-llava-v1.5-7b-finetune-6993k \
-    --answers_file ./test_6.jsonl \
-    --question_extension "Respond in following JSON format: {\"reasoning\": \"your reasoning\", \"answer\": \"your answer\"}"
-
-python eval/mmbench_en/mmbench_en_eval.py \
-    --model_path $CKPT_DIR/llava-TPU-llava-v1.5-7b-finetune-6993k \
-    --answers_file ./test_8.jsonl \
-    --question_extension "Respond in following JSON format: {\"reasoning\": \"your reasoning\", \"answer\": \"your answer\"}"
-"""
diff --git a/eval/scripts/run_benchmark.sh b/eval/scripts/run_benchmark.sh
@@ -126,4 +126,4 @@ done
 python $test_file --answers_file "$answers_file"
 
 echo "Done evaluation and testing for $benchmark on model at $ckpt with conversation mode $conv_mode"
-echo "Answers file: $answers_file"
+echo "Answers file: ${(realpath $answers_file)}"