#171 issue : Update script.sh #175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birm
requested changes
Aug 16, 2024
Comment on lines
+46
to
+53
| if [[ ! -d ../caracal/config ]]; then | ||
| echo "../caracal/config does not exist" | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ ! -d ../Distro/jwt_keys ]] | ||
| then echo "../Distro/jwt_keys does not exist" | ||
| exit | ||
| if [[ ! -d ../caracal/jwt_keys ]]; then | ||
| echo "../caracal/jwt_keys does not exist" | ||
| exit 1 |
There was a problem hiding this comment.
I think you've misunderstood this context. This assumes you're deploying the caMicroscope stack without docker. So we assume you have relevant config from Distro.
This could be made more independent by copying/renaming the required files (e.g. make an empty jwt_keys dir, copy routes.json from an example, etc)
I'm not sure how useful this is in practice; I'm not aware of anyone deploying caracal this way currently.
Please let me know if you want help with this.
There was a problem hiding this comment.
Would be grateful if you help me a bit.I am new to open source contribution so I would appreciate your help very much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Questions