Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logger): add logger, console->logger migration #78

Closed
wants to merge 1 commit into from
Closed

feat(logger): add logger, console->logger migration #78

wants to merge 1 commit into from

Conversation

YashKumarVerma
Copy link
Contributor

Description

  • adds Winston as a dependency for logger
  • adds transports to write logs to file
  • adds separate transports for errors and Infos
  • migrates existing codebase from console -> logger

Motivation and Context

How Has This Been Tested?

  • linting tests
  • existing tests do not fail.

Screenshots (if appropriate):

  • N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@YashKumarVerma
feat(logger): add logger, console->logger migration
b95c67c 
- adds winston as a dependency for logger
- adds transports to write logs to file
- adds separate transports for errors and infos
- migrates existing codebase from console -> logger
@YashKumarVerma YashKumarVerma mentioned this pull request Mar 23, 2021
Closed
6 tasks
@YashKumarVerma
Copy link
Contributor Author

closing in favor of #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YashKumarVerma