Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info modal fixed for different window sizes #885

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

We13b-MD
Copy link

@We13b-MD We13b-MD commented Mar 27, 2024

Summary: Responsive Info Modal Layout

Description:

This pull request modifies the CSS styles for the info modal to create a responsive layout that adapts to different window sizes. This ensures the modal content, particularly the table headers ("Name," "Classes," etc.), displays properly on desktop and mobile devices.
Motivation:

The previous info modal layout caused table headers to overflow on mobile devices, potentially hindering readability and user experience. This change addresses that issue by making the modal responsive, allowing headers to stack vertically on smaller screens.

Testing:

The changes have been tested thoroughly on various screen sizes (desktop, tablet, mobile) using browser developer tools to simulate different viewports.
Functionality of the info modal and its content remains intact across all tested screen sizes.

Results

Before Change

infoviewererrorwithmobileresponsive.mp4

As you can see here the in the info modal the edit class list info overlaps on mobile devices and when the window size is at about 439px which is not good for readability and it is also a bad user experience.

After Change

correctinfomodalaccordingtobirm2.mp4

In this video the info modal was corrected by adjusting the table element and increasing the modal-box to suit the table in mobile view. This will stop the overflow of the table elements which enhances readability and user experience. CSS styles were applied to handle extreme window sizes, preventing layout distortions and maintaining usability.
Tested the adjustments across various screen sizes, including extreme cases like 100px width, to ensure consistency and effectiveness.

@We13b-MD
Copy link
Author

@birm pull request corrected one file changed i made some errors pushing code

@birm birm changed the base branch from master to develop March 31, 2024 04:30
@birm
Copy link
Member

birm commented Mar 31, 2024

This is notably better for medium size screens (e.g. half my laptop monitor) but still behaves erratically when especially small.
(develop)
Screenshot 2024-03-31 at 12 34 14 AM

(this PR)
Screenshot 2024-03-31 at 12 34 02 AM

Maybe it'd be better to just do overflow scroll under a certain size?

I know I'm picking the strangest kind of edge case here, so I'm still willing to merge it, just let me know what you decide.

@We13b-MD
Copy link
Author

Thank you @birm overflow scroll is a better option after I did my research I will implement it today and get back to you

@We13b-MD
Copy link
Author

We13b-MD commented Mar 31, 2024

@birm updated the video and used the overflow property as you requested implemented the changes and it is much better than the previous one you can check the screen record after the "After changes" Heading.

@We13b-MD
Copy link
Author

We13b-MD commented Apr 3, 2024

@birm still waiting for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants